Closed cardenca closed 3 weeks ago
@cardenca thanks for the PR! Can you push a new commit to this PR to add yourself to the list of contributors in the v0.11.1 file in https://github.com/pvlib/pvlib-python/tree/main/docs/sphinx/source/whatsnew?
@kandersolar I'm sorry for the delay. I already pushed the changes! thanks.
@cardenca it looks like you made the changes in a new PR (#2197) instead of updating this one. It is better to make all related changes in a single PR. Can you please redo the "what's new" edit in the branch for this PR (it is called iss2159
), and close #2197?
Thank you!
@kandersolar now I think I did it well, thank you for the correction!
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.