Update GH action versions

pvlib / pvlib-python

A set of documented functions for simulating the performance of photovoltaic energy systems.

https://pvlib-python.readthedocs.io

BSD 3-Clause "New" or "Revised" License

1.21k stars 1.01k forks source link

Update GH action versions #2223

Closed AdamRJensen closed 1 month ago

AdamRJensen commented 1 month ago

Duplicate of #2218

[x] I am familiar with the contributing guidelines
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The current versions of the tools used in the GH actions are outdated and are emitting warnings:

Used the replace-all function in Visual Studio Code that handles all files in a repository link

echedey-ls commented 1 month ago

You may want to compare against #2218

P.S.: when did you become part of the VSCode gang? 🤩

AdamRJensen commented 1 month ago

You may want to compare against #2218

P.S.: when did you become part of the VSCode gang? 🤩

Here I was all proud of using VSCode and then it's a duplicate PR - sorry @echedey-ls. I think we should merge either one of the two (they're identical now). I don't want to see warnings and the old actions are security supported any longer and we should take security seriously.

echedey-ls commented 1 month ago

You may want to compare against #2218 P.S.: when did you become part of the VSCode gang? 🤩

Here I was all proud of using VSCode and then it's a duplicate PR - sorry @echedey-ls. I think we should merge either one of the two (they're identical now). I don't want to see warnings and the old actions are security supported any longer and we should take security seriously.

Nah man it's all good! Bonus points if you used a regex (PCRE2 flavour if you are into that kinks, it's the famous ripgrep I talk about everywhere).

Continue with this one; in fact, I did not see any warnings when I published those changes, it was for the sake of easing long-term maintenance, so I closed it when they weren't necessary.

AdamRJensen commented 1 month ago

@echedey-ls Want to leave a review?