pvlib / solarfactors

A community-maintained implementation of the pvfactors bifacial irradiance model
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

PVEngine.skip_step is not used #10

Open kandersolar opened 1 year ago

kandersolar commented 1 year ago

Originally posted in https://github.com/SunPower/pvfactors/issues/139:

PVEngine creates a mask indicating values that need not be considered in the calculation:

https://github.com/pvlib/solarfactors/blob/21d48655ce6acd3ab1955f98212cbdd3e3cc8351/pvfactors/engine.py#L170-L175

However, that mask is not actually used anywhere today. It used to be, but it looks like it stopped being used in #84 during the switch from iterative to vectorized code.

I think the underlying concept may still be useful even in the current vectorized approach, so I think it's probably worth seeing if we can start using it again somehow, otherwise it should just be deleted IMHO.