pvlib / twoaxistracking

twoaxistracking is a python package for simulating two-axis tracking solar collectors, particularly self-shading.
https://twoaxistracking.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Add test & coverage CI job #15

Closed kandersolar closed 2 years ago

kandersolar commented 2 years ago

Setting up some minimal pytest and coverage infrastructure. Leaving as a draft PR for now because it might take some iterating.

AdamRJensen commented 2 years ago

I believe we talked about installing shapely using conda explicitly in the test.yml file - is this still the plan?

kandersolar commented 2 years ago

I think the problem with shapely was related to doing pip install shapely when in a conda environment on Windows. Since the tests aren't using conda environments (and also not running on Windows), I think there is no need for conda here.

However, it seems that this is no longer an issue with the latest shapely releases -- installing shapely from PyPI on windows now seems to work fine for shapely>=1.8.0. The last version I get that lgeos error with is shapely==1.7.1. See https://github.com/shapely/shapely/pull/1108.