Improve support for Internet Explorer

pvorb / clone

deeply clone arbitrary objects in javascript

https://www.npmjs.com/package/clone

MIT License

781 stars 129 forks source link

Improve support for Internet Explorer #77

Closed c-w closed 7 years ago

c-w commented 7 years ago

This pull request fixes two bugs with cloning Maps and Sets on IE:

IE requires the type argument to instanceof to be defined.
IE does not implement Map.keys() and Set.keys().

These bugs currently cause the "clone a native Map" and "clone a native Set" tests in test.html to fail on Internet Explorer:

After applying the changes in this pull request, all the test-cases in test.html pass on Internet Explorer, Chrome and Firefox.

pvorb commented 7 years ago

Yes, I also had a look and everything looks good to me.

@c-w Thanks for testing this on IE and fixing the issue right away. If you'd like to be mentioned in the package.json, feel free to add yourself to the list of contributors and push again on your branch.

c-w commented 7 years ago

@rictic Thanks for the signoff. @pvorb Thanks for the suggestion. Done.

pvorb commented 7 years ago

BTW, v2.1.1 is on npm

c-w commented 7 years ago

Thanks for the quick merge and version bump. I encountered these bugs while working with QuillJS so maybe we'll enable them to support older versions of IE now too.

pvorb commented 7 years ago

That project looks promising, didn't know about it. Nice to see you can make use of this little library.