search

pvpgn / pvpgn-server

Next generation of PvPGN server
https://pvpgn.pro
GNU General Public License v2.0
554 stars 157 forks source link

BUG Crash Miragebot #107

Closed anonbyte closed 9 years ago

anonbyte commented 10 years ago

the pvpgn will crash if login with miragebot (wc3 tft) then Profile -> Lookup -> Ladder -> chose anyone of this :

  1. StarCraft
  2. StarCraft Broodwar
  3. Warcraft II
  4. Warcraft II Iron Man

http://pastebin.com/8g9CpPk2

anonbyte commented 10 years ago

ASAP please someone fix this, someone if use this, my pvpgn will crash.

HarpyWar commented 9 years ago

I can't get MirageBot working to connect PvPGN - MirageBot always crashes (but not PvPGN).

Try it with the latest code, may be it was fixed in https://github.com/HarpyWar/pvpgn/commit/23f03d6060cca282c4092474ddecb800f4b6a333

anonbyte commented 9 years ago

harpy whats info im missing? im already post the debug info in pastebin. this bug also for 1.99 and 1.85

HarpyWar commented 9 years ago

Sometimes it's hard to determine a low-level problem only by a stacktrace.

If I understand you correctly to reproduce a crash I need login to a server using program MirageBot and open a user's profile. Right? If so then show me how to login to PvPGN after I've downloaded MirageBot.

anonbyte commented 9 years ago
  1. Download MirageBot here http://www.mediafire.com/download/6a4m6vrkf53lzau/X.2041.Public.Portable.zip
  2. Profile -> Configuration -> Create -> ProfileName ->
  3. See this printscreen http://upload.forumdota.com/images/imagesmiragebot2.png

CdKey : n72224jd477fhjxhrc77v26g9p Expansion : JD6DY7Z7VERH6YW4X8EFWNBR6J

save profile

  1. Profile -> Connection -> Change BNLS -> Edit Servers Replace all server with "bnls.mattkv.net" -> Save -> Restart/Reopen MirageBot
  2. Profile -> Choose profile already u create
  3. to connect press F6 / Profile -> Connection-> Connect

To reproduce a crash when login Profile -> Lookup -> Ladder -> chose anyone of this :

  1. StarCraft
  2. StarCraft Broodwar
  3. Warcraft II
  4. Warcraft II Iron Man
HarpyWar commented 9 years ago

I always receive error:

(17:32:36) -- PvPGN: Incorrect password specified!
(17:32:36) -- PvPGN: Disconnected!

Even with a new account:

(17:39:34) -- PvPGN: Account created successfully!
(17:39:35) -- PvPGN: Incorrect password specified!
(17:39:35) -- PvPGN: Disconnected!

A password hash that calculated by MirageBot is differ from PvPGN hash (as I see when debugging).

MirageBot hangs up when I trying connect using Starcraft game client.

anonbyte commented 9 years ago

are u already check "Force old login system packets (PvPGN)" ?

see this pictures http://upload.forumdota.com/images/imagesmiragebot2.png

HarpyWar commented 9 years ago

Well, it connects when this option is checked. But where can I find Profile -> Lookup -> Ladder? I only see Profile item in context menu without Lookup or Ladder items/tabs: miragebot

There are several errors in logs when opening self profile, may be it should be set as warns. I will explore this later. But there is no a crash. Tested on Windows with the latest PvPGN.

Nov 01 10:46:36 [error] pvpgn::bnetd::clan_get_name: got NULL clan
Nov 01 10:46:36 [error] pvpgn::packet_append_string: got NULL string
Nov 01 10:46:36 [error] pvpgn::bnetd::clanmember_get_status: got NULL clanmember
Nov 01 10:46:36 [error] pvpgn::bnetd::clanmember_get_join_time: got NULL clanmember
anonbyte commented 9 years ago

not profile, see this printscreen

miragebug

HarpyWar commented 9 years ago

Thanks, I confirm the crash.

Stack trace is different from yours that in the first message. I presume it was a bug that was fixed recently (as I said in the third message of the topic).

HarpyWar commented 9 years ago

Fixed.

anonbyte commented 9 years ago

thanks you so much