pvpgn / pvpgn-server

Next generation of PvPGN server
https://pvpgn.pro
GNU General Public License v2.0
556 stars 155 forks source link

Improve README.md for building on Linux/Ubuntu 20.04 #440

Closed trungklam closed 3 years ago

trungklam commented 3 years ago
trungklam commented 3 years ago

This fix the issue below: happiness:/mnt/c/desktop/pvpgn-server$ cmake -G "Unix Makefiles" -H./ -B./build -- pvpgn is used as APPLICATION_NAME -- {fmt} -- Version: 7.1.3 -- Build type: -- CXX_STANDARD: 11 -- Required features: cxx_variadic_templates -- {fmt} CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR) Call Stack (most recent call first): /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.16/Modules/FindCURL.cmake:143 (find_package_handle_standard_args) ConfigureChecks.cmake:43 (find_package) CMakeLists.txt:30 (include)

RElesgoe commented 3 years ago

The code in the develop branch depends on libcurl but the code in the master branch doesn't. That's why the build instructions in README.md are different in both branches.

trungklam commented 3 years ago

I see. I didn't pay attention on it ;) thank you !