search

pvpgn / pvpgn-server

Next generation of PvPGN server
https://pvpgn.pro
GNU General Public License v2.0
541 stars 155 forks source link

Finalize 1.99.8.0.0 release #444

Open RElesgoe opened 3 years ago

aperture147 commented 2 years ago

It's 5 months now :( is this pull request still being active?

onlyjob commented 2 years ago

Please do not commit common third party libraries like zlib, which is already shipped by all major GNU+Linux distributions.

See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

RElesgoe commented 2 years ago

Please do not commit common third party libraries like zlib, which is already shipped by all major GNU+Linux distributions.

See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

These libraries were committed to facilitate easier compilation on Windows platforms where easy to use package managers do not exist.

Though, now that I'm checking the CMake code, I see that the condition for including the committed zlib is not guarded by the WIN32 variable (https://github.com/pvpgn/pvpgn-server/blob/develop/ConfigureChecks.cmake#L52-L55). This will need to be changed before merging this pull request.