pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox
Other
31 stars 8 forks source link

Yet Another Station Issue.. #103

Open FlapMyJax opened 2 years ago

FlapMyJax commented 2 years ago

So, This has been going on for almost an entire month, I've gone from removing and re-adding the Addon, fucking around with the theme, restarting my PC several times, and even removing and re-adding the physical stations on the Pandora site, to no Avail. And this is only with a select few of stations, I appreciate this Addon alot for my music pleasures, But issues are becoming very often, Please tell me in any-way to fix this, I'd appreciate it.

https://user-images.githubusercontent.com/87390741/171339230-157d4400-50b2-49bb-91d9-b6213471728a.mp4

.

hucario commented 2 years ago

I think I may know what the issue is here. This is a first-glance reaction, so it's entirely possible I'm wrong, but if you don't add any feedback (dis/liked songs) a station doesn't really count as being "in your library", per se. Have you tried adding another station seed from the Pandora web client? i.e. instead of just Ice Nine Kills radio, making it Ice Nine Kills + some specific Ice Nine song? Once it's unique it should​ count in your library just fine. If that doesn't work, I'll go more in-depth with investigation

Sent with Proton Mail secure email.

------- Original Message ------- On Tuesday, May 31st, 2022 at 11:13 PM, Jaxon Fitz @.***> wrote:

So, This has been going on for almost an entire month, I've gone from removing and re-adding the Addon, fucking around with the theme, restarting my PC several times, and even removing and re-adding the physical stations on the Pandora site, to no Avail. And this is only with a select few of stations, I appreciate this Addon alot for my music pleasures, But issues are becoming very often, Please tell me in any-way to fix this, I'd appreciate it.

https://user-images.githubusercontent.com/87390741/171339230-157d4400-50b2-49bb-91d9-b6213471728a.mp4

.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

FlapMyJax commented 2 years ago

I've tried this over the last week to no progress. ;l

hucario commented 2 years ago

Well, there are only two points of failure I can think of.

If it's the first, there's nothing to be done. If it's the second, it'll be somewhat easy to debug. I'll look through the code handling stations and see if there are any filters there that may be getting rid of the stations

hucario commented 2 years ago

As per common/js/anesidora.js:122, Anesidora backend directly passes the Pandora response without modifying or editing the stations list at all, so any editing would have to be in the frontent side (newpopup.js). Frontend side initiates a stations refresh (newpopup.js:205), backend (as seen above) returns it direct from pandora. There is a bit of filtering for the search bar done on line 222, but if there's nothing in the search bar it shouldn't do anything, so it's not the problem. Thus, the problem almost certainly is not on our side, as we don't filter the stations list much and the filtering we do doesn't cause that.

If you want to make absolutely sure, you can paste this:

code
async function getStationList() {
    let request = JSON.stringify({
        "userAuthToken": userAuthToken,
        "syncTime": getSyncTime(syncTime),
        includeStationArtUrl: true
    });
    let response = await sendRequest(false, true,"user.getStationList", request);
    console.log(response.result.stations.map(e => e.stationName));
    stationList = response.result.stations;
    stationList.forEach(e => {
        stationImgs[e.stationToken] = e.artUrl;
    })
    localStorage.stationImgs = JSON.stringify(stationImgs);
    if (localStorage.userStation === undefined) {
        response.result.stations.forEach(function (station) {
            if (station.isQuickMix) {
                localStorage.userStation = station.stationId;
            }
        });
    }
    return stationList;
}

into Anesidora's console by following this video:

https://user-images.githubusercontent.com/50851047/172938182-bd5b10b5-4c60-4189-869c-1fac50d0940f.mp4

What'll pop up in the debug console is the complete list of stations we get from Pandora. If your stations show up there (but not in the UI) then I'll investigate further. If not, there's nothing we can do - we can't generate data from nothing.

FlapMyJax commented 2 years ago

Is there by chance a Cap in how many stations can be loaded in at a time or something like that?, I'm hitting 95 when I know there are probably close to at-most 110