search

pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox
Other
31 stars 8 forks source link

Theme list + a few code comments #56

Closed hucario closed 4 years ago

hucario commented 4 years ago

Whoops, forgot that I commented through newplayer.js. oh well. Added a theme list to theming.htm that checks https://pvrs12.github.io/AnesidoraThemes

pvrs12 commented 4 years ago

I may hold off on this for V2 right now. It's something I want to think over before committing (ba dum tss) to.

I have 4 major concerns:

  1. The hosting on github issue that you brought up. I don't think we're going to end up with any massive library of themes, but I don't want to tempt fate.
  2. This currently parses from ThemeList.md, if for some reason something in that changes then it will cause issues with the theming.htm page
  3. If we do end up with a lot of themes then loading them like this will cause the data transferred in Anesidora to skyrocket when opening the themes page. The PNGs are coming in around 200-400K each. We should be able to do some live-preview stuff by just loading the much smaller JSON
  4. I think the current placement is likely to be missed by people. I might prefer a separate page? IDK

I don't think you should spend too much time working on this right now unless you're feeling particularly passionate (or bored). Once V2 is out and I get some read on if people are using the themes (PRs to the theme repo) then I'll dig into it again (and let you know on this PR!)

hucario commented 4 years ago

Alright! Sounds good. It didn't take too much time to make, so I'm fine if it doesn't get included.