search

pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox
Other
31 stars 8 forks source link

Feature request: hotkey support #6

Closed elijahgagne closed 6 years ago

elijahgagne commented 6 years ago

Would you be willing to add support for hotkeys? The specific use case I'd like to cover is pausing/playing with hotkeys, hopefully without having the give the plugin focus.

pvrs12 commented 6 years ago

Sure, I should be able to add that fairly easily. The documentation for it is straightforward (https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands) and the additional code should be minimal

I'll update when I've got something working

ksariash commented 6 years ago

+1 to this request. Would be nice if this included support for media hotkeys

pvrs12 commented 6 years ago

I've added support for hotkeys in Firefox. I wasn't able to get anything working for Chrome quite yet. Also, it looks like there is a bug in Firefox currently. All 4 Media keys are being detected identically (as MediaPlayPause). As a result I've had to bind the Next Track command to Alt+N instead of MediaTrackNext.

TL;DR:

This should be available in the next version on the store (1.11.0)