search

pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox
Other
31 stars 8 forks source link

Firefox android - not playing next song automatically #84

Open swan77777 opened 3 years ago

swan77777 commented 3 years ago

Hello again, So when a song finishes, it does not automatically move and play the next song (Firefox Nightly on Android). I can advance it manually by pressing the next song button on the screen, however. Is there a setting I should be changing to allow the auto-advance? Thanks.

pvrs12 commented 3 years ago

I'll check into this. There isn't any setting for it and it should happen automatically.

swan77777 commented 3 years ago

I saw you pushed a fix - the screen for Anesidora is now a blank window when I open it. My phone just updated so it may have been something on my end. Does it still work fine for you? Thanks again.

pvrs12 commented 3 years ago

Heh, well it did work, but #85 happened due to mistakes I made... Once those square out I'll update this again

swan77777 commented 2 years ago

Hello, just seeing if there's been any updates with this issue, in case it got forgotten or buried somehow. Thanks.

pvrs12 commented 2 years ago

Tbh, I haven't worked on this addon in ages. Been really busy with real work...

This one is also pretty low priority since there's only 2 android users right now and I think one of them is me.

This is open if you or anyone wants to try to tackle it. I'll accept the PRs

On Tue, Sep 7, 2021, 12:37 PM swan77777 @.***> wrote:

Hello, just seeing if there's been any updates with this issue, in case it got forgotten or buried somehow. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pvrs12/Anesidora/issues/84#issuecomment-914457477, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVCK4M3LFPWW3SVLTYDWNLUAY5VHANCNFSM46DENR2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lovelydumpling commented 2 years ago

To be fair, I'm still having the issue on Chrome (Brave) where it stops automatically playing after a few tracks, and I have to skip to the next song manually myself. I wonder if the two issues are related.

hucario commented 2 years ago

I can confirm this happens to me occasionally. It's probably a network thing (request fails and doesn't retry?) so I'll keep devtools for Anesidora open in the background logging network requests and with conditional breakpoints to try to find it.

hucario commented 2 years ago

alright, I don't know if this is the cause but this is a separate bug I found: You see this? This line of code right here? image It indicates whether the previous request failed. Guess what? It's in the wrong place. It's defined in the function, which means it always is false. So Anesidora fails station.getPlaylist(), and because of this line here: image It retries again, and again, and again. Causing many requests to go to Pandora, which is not good and causes them to rate limit you, which means it never solves.

I'll put through a PR to fix this Soon:tm:

pvrs12 commented 2 years ago

https://github.com/pvrs12/Anesidora/actions/runs/1487849746 @swan77777 is it possible for you to test the builds in this?

https://github.com/pvrs12/Anesidora/pull/96

i believe this should fix the android issues

nswanson777777 commented 2 years ago

Hey this is swan77777 (lost access to old github account). Sorry for the late reply. I just reinstalled Anesidora for Firefox Nightly on Android, and it still is not automatically going to the next song. Let me know if you want me to test anything on my end. Thanks.

nswanson777777 commented 2 years ago

Actually I'm not sure that I'm getting the changes on the adroid_fixes branch. The date of the code pulled is the same but it looks like the master branch was also updated on that same date. I don't have an easy way to check this further on my phone, and I don't see a way to pull a specific branch of the code inside Firefox Nightly Android.

hucario commented 1 year ago

Reconfirming - just got Firefox Nightly for Android, and the bug still exists. Anesidora works on desktop, which means that the issue is almost certainly a webcompat issue which is pain. I'm hoping that the issue is in platform_specific.js, because then I can just move calling that to after the listeners and everything will work again. If it's not that, it means I have to go looking around the code for whatever it is that FFNA doesn't support. It's also possible that it's an issue with Android's battery saver stopping the process in the background, but it doesn't look like that's the case based on the symptoms (would probably halt in the middle of a song, rather than stopping the playing of new ones)

Bolongna commented 1 year ago

I can duplicate this issue on chrome but it is easy to fix on chrome. To make it happen, sign in to pandora in another window, then don't sign out, then use Anesidora as normal. It will play one to two songs and stop. Then click next and it does the same. If you then go and sign out it will still act the same way until you delete the cookies and then it starts working again. Not sure if that helps or not.