search

pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox
Other
31 stars 8 forks source link

V2.2.2 Fails on Firefox/Windows #85

Closed rfi54 closed 3 years ago

rfi54 commented 3 years ago

V2.2.2 for Firefox (89.0 64 bit) on Windows seems to be broke. The Anesidora Icon is blank and when I open it, the window is blank. I tried removing and re-installing Anesidora but no change.

hucario commented 3 years ago

attempting to reproduce

hucario commented 3 years ago

yeah, that's a problem alright. works fine on chrome, but firefox is bugging out something big

hucario commented 3 years ago

so... for some reason this url fails: jar:file:///path/to/anesidora_firefox.xpi!/images/anesidora-48.png but this succeeds: jar:file:///path/to/anesidora_firefox.xpi!/images%5Canesidora-48.png I don't know if that's actually relevant but it appears to be the reason it looks so odd on about:extensions @pvrs12, I have no idea what's going on. Any thoughts?

pvrs12 commented 3 years ago

Jeeze. I definitely didn't test enough

It for sure has to do with https://github.com/pvrs12/Anesidora/commit/b6fd3174d192aa2815d129554bf49668eea2cddd

hucario commented 3 years ago

aaand with that I'm leaving you with the mess because you sound like you know what caused this

pvrs12 commented 3 years ago

Oh wow, this may be one of the dumber errors... it looks like it's related to the packaging script updates that I had attempted...

pvrs12 commented 3 years ago

So it should be fixed. If you want to update immediately you can remove Anesidora and reinstall from the Mozilla addons page https://addons.mozilla.org/en-US/firefox/addon/anesidora/

rfi54 commented 3 years ago

Seems to work now. Thanks guys for the quick work!

pvrs12 commented 3 years ago

@rfi54 can you confirm what version you have installed?

You should be able to see it from about:addons and looking at Anesidora details

image

rfi54 commented 3 years ago

2.2.1_revert2.

pvrs12 commented 3 years ago

Oh, sorry. There was another comment here that said it hadn't worked. Since you're good I'm going to close.

Thanks for the report and confirm!