Replaced url css with img to enable lazy loads

pvrs12 / Anesidora

Anesidora - Pandora extension for Firefox

Other

31 stars 8 forks source link

Replaced url css with img to enable lazy loads #91

Closed pvrs12 closed 2 years ago

pvrs12 commented 3 years ago

Instead of doing inline styling and adding url to a div for the images I swapped to use img with the loading=lazy attribute. This allows the main currently playing song to load much quicker

pvrs12 commented 3 years ago

@hucario Can you give this a glance? I'm not a UI/CSS hero, so you're better suited to know if this will break anything. I didn't have any issues in testing... but who knows

hucario commented 3 years ago

Yep, it breaks the "click to view station/album on pandora" functionality as you're changing an a to an img. Oh well, afaik nobody used it anyways. Either way it shouldn't affect song loading much, as (again afaik) the audio has a higher priority than images.

lovelydumpling commented 2 years ago

"Oh well, afaik nobody used it anyways." Can confirm, only ever use it on accident when trying to switch to the other tabs.