pvvx / ZigbeeTLc

Custom firmware for Zigbee 3.0 IoT devices on the TLSR825x chip
Other
365 stars 20 forks source link

Add pvvx to Manufacturer Name #50

Closed krzysztof-kwitt closed 7 months ago

krzysztof-kwitt commented 8 months ago

Hello,

It is difficult to recognize what CFW we have on a specific device, so I suggest that we also add the author's name to the manufacturer name field, which will make it easy to find out who the firmware comes from.

For now, it is possible to recognize the author only on the basis of OTA Upgrade (0x19) cluster, which is not very obvious and user-friendly.

I'm not sure what implications this will have, but I think it's worth discussing how we can recognize what CFW we have on the device in a more user-friendly way.

CC: @devbis

pvvx commented 8 months ago

ZigBee Cluster Library Specification 3.2.2.2.5 ManufacturerName At tribute The ManufacturerName attribute is a maximum of 32 bytes in length and specifies the name of the manufacturer as a ZigBee character string.

I'm not a 'manufacturer'. Don't confuse Zigbee 3.0 standards with Tuya quirks

krzysztof-kwitt commented 8 months ago

I wanted to update the field. This is what it looks like in Zigbee2MQTT. Screenshot 2024-02-04 at 21 07 19 Screenshot 2024-02-04 at 21 07 30

This field can be used as a fingerprint in Zigbee2MQTT. https://github.com/Koenkk/zigbee-herdsman-converters/blob/0fcaeef8210c6c2635abe85c37e2a26c6f17d4f3/src/lib/types.ts#L35-L40

The word manufacturer in this case can be interpreted in different ways.

This is important for me to solve problems like: https://github.com/Koenkk/zigbee2mqtt/issues/21165 Do you have another idea for recognizing whether your CFW or CFW authored by @devbis is installed? I am thinking about recognition based on software version (static list) for already released versions of your and devbis CFW. Newer versions will be recognized based on the new Zigbee manufacturer's name

devbis commented 8 months ago

@krzysztof-kwitt A better option is to add pvvx to device model name as z2m uses zigbeeModel as a primary recognition property. E.g. LYWSD03MMC/pvvx

pvvx commented 8 months ago

Due to the distribution by "ModelIdentifier" and "ManufacturerName", many Tuya Zigbees do not work. The firmware version is different, but the name is the same.

devbis commented 8 months ago

It is applicable only to original Tuya firmwares with proprietary cluster with datapoints. Doesn't make sense for custom firmwares.