search

pwa-builder / CloudAPK

Build Android APK packages on the cloud
Other
147 stars 44 forks source link

Building android app generates inernal server error #20

Closed amanintech closed 4 years ago

amanintech commented 4 years ago

After adding the URL and finally clicking on download generates an internal server error image

ghost commented 4 years ago

Hello amanintech, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

andreban commented 4 years ago

I can repro that. Here's the error message I get from the request:

Invalid PWA settings: name is required

Here's way the payload sent to generateSignedApkZip looks like:

{
    "packageId": "com..twa",
    "host": "pwa-directory.appspot.com",
    "name": "",
    "themeColor": "transparent",
    "navigationColor": "transparent",
    "backgroundColor": "transparent",
    "startUrl": "/manifest.json",
    "iconUrl": "https://pwa-directory.appspot.com/favicon.ico",
    "maskableIconUrl": null,
    "appVersion": "1.0.0",
    "useBrowserOnChromeOS": true,
    "splashScreenFadeOutDuration": 300,
    "enableNotifications": false,
    "shortcuts": [],
    "signingInfo": {
        "fullName": "John Doe",
        "organization": "Contoso",
        "organizationalUnit": "Engineering Department",
        "countryCode": "US"
    }
}

Another point is that the generated packageId is also invalid: com..twa.

JudahGabriel commented 4 years ago

Woops, looks like something broke on our deploy. We should have a fix for you Monday or Tuesday.

jgw96 commented 4 years ago

Hello all! Looks like our service went down over the weekend, i am looking into things now and will respond when fixed (:

jgw96 commented 4 years ago

Hey all! The service is now back up and running, sorry for the issues! Since the service is back up I am going to close this for now but @JudahGabriel , on Tuesday lets talk about what i found and we can open an issue to fix the deeper cause.

amanintech commented 4 years ago

It still returns error image

JudahGabriel commented 4 years ago

@amanintech working on this end - I'm successfully generating an APK. Can I ask what URL you're using?

amanintech commented 4 years ago

It doesn't work reliably. Sometimes it does sometimes it doesn't. I am trying to retrace the network call and more information about the error.

Also, I think the styling part doesn't generate the right manifest file.

eg. I chose the standalone display view of the PWA but still, the generated app had it with the address bar. Is it supposed to be like that? or should I raise a separate issue explaining the error?

JudahGabriel commented 4 years ago

Let me know if there's a consistently failing URL.

If your packaged APK is showing with address bar on Android, you probably forgot to include your digital asset links.

When you download your Android app package from pwabuilder, your zip file will contain a Next-steps.md which tells you what you need to do:

Digital Asset Links

To validate that you own your PWA's domain, you'll need to deploy a Digital Asset Links file to your server. The TWA Quick Start Guide explains how.

Follow those steps to deploy your digital asset links file, then your APK will load without address bar on Android.