Add "Meta Quest compatible" flag

pwa-builder / CloudAPK

Build Android APK packages on the cloud

Other

144 stars 44 forks source link

Add "Meta Quest compatible" flag #98

Closed FluorescentHallucinogen closed 1 year ago

FluorescentHallucinogen commented 2 years ago

Fixes https://github.com/pwa-builder/PWABuilder/issues/3154.

ghost commented 2 years ago

Thanks FluorescentHallucinogen for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

FluorescentHallucinogen commented 2 years ago

@jgw96 @JudahGabriel This pull request is ready to review and merge. :wink:

JudahGabriel commented 2 years ago

@amrutha95 @jgw96 Have a look at this?

amrutha95 commented 2 years ago

Hey @FluorescentHallucinogen , thank you so much for this PR! We are just waiting on talking to Meta who we've been partnering with to create the current Meta Quest packaging service. Will keep you updated.

FluorescentHallucinogen commented 2 years ago

@amrutha95

We are just waiting on talking to Meta

FYI, I was in close contact with @jacobrossi and @pampas93 from the Meta team while developing the related pull request for Bubblewrap to ensure that generated APKs meet all requirements and successfully pass all server-side validations for publishing to App Lab and Oculus Store. I.e. this feature already implemented in Bubblewrap 1.18.0, and this pull request only needed for adding the corresponding UI to PWABuilder. It doesn't remove anything (e.g. ovr-platform-util) from PWABuilder (this can be done later in a separate pull request). So IMO currently there is nothing that prevents this pull request from being reviewed and merged. 😉

amrutha95 commented 1 year ago

@khmyznikov or I will get this tested and merged ASAP.

khmyznikov commented 1 year ago

@khmyznikov or I will get this tested and merged ASAP.

Works for me