Allow disabling the offline feature

pwa-builder / ManifoldCordova

JS Plugin for Cordova

Other

94 stars 93 forks source link

Allow disabling the offline feature #72

Closed vjrantal closed 8 years ago

vjrantal commented 8 years ago

The feature can be disabled with mjs_offline_feature property in the manifest.json file.

Fixes #61.

msftclas commented 8 years ago

Hi @vjrantal, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Ville Rantala). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

vjrantal commented 8 years ago

@boyofgreen: Thanks for merging this!

I wanted to say that I only did manual testing for the cases where the offline feature is disabled, but didn't yet have time to do a thorough regression testing. If someone sees any issues after these changes, feel free to file an issue and assign to me and I'll try to fix.