pwa-builder / PWABuilder-CLI

Node.js tool for App Generation
Other
1.63k stars 142 forks source link

Default badge images provided by manifoldjs for Windows Apps, fail the Windows store submission #219

Closed AmazingJaze closed 7 years ago

AmazingJaze commented 8 years ago

The Windows store submission only allows badge images to contain white or transparent colors. The 2 default badge images provided by manifoldjs when an app does not provide a manifest, contain other colors.

Submitting any app using these images, to the Windows Dev Center for store submission fails the submission process.

image

AmazingJaze commented 8 years ago

Ideally, submitting a manifold generated package to the store would just work.

When looking through the generated manifest and appxmanifest, the only place I can see images/BadgeLogo.png referenced is in windows10/appxmanifest.xml.

image

I assume the windows store must require all apps to include a lockscreen badge icon? I'm not able to test it by modifying my source and resubmitting at the moment.

AmazingJaze commented 8 years ago

I removed the Badge Icon from my manifoldJS generated manifest before repackaging and resubmitting to the windows store this morning. Should be at least a day to get results back.

In the mean time I compared this to the package output generated by Windows App Studio, and it would appear they don't even include a <uap:LockScreen /> tag in the appxmanifest.xml when the input URL doesn't provide a web manifest. I can also confirm that I've already previously submitted their package to the store successfully, so it would appear that badge icon's are not a requirement and manifoldjs could just remove it from the generated windows 10 manifest as a work around to pass the store's certification check.

That being said, its nice to be able to demo the lock screen badge functionality in cases like this where user's don't already have one. @boyofgreen do you or @f2bo have the resources to generate a monochromatic version of the current badge icon?

boyofgreen commented 8 years ago

we don't have a way to make it images non-rgba yet, but it's in the roadmap. So we do have a transparent BG, but I guess it needs to just be black and white. I think the easy fix is to make the default image black and white for that size. Wouldn't that be prefered to removing it?

marcoscaceres commented 8 years ago

Related: https://github.com/w3c/manifest/issues/480

AmazingJaze commented 8 years ago

@boyofgreen Just to be clear, it appears the error is that the badge icons are red and transparent. If we were to use white and transparent images instead, that should resolve the problem and would be preferable to removing badge icons.

boyofgreen commented 8 years ago

I think we can move the default image for the badge to black and white for now, then add a check in later during download to check the image for windows10. if the W3C spec takes in badge, we will follow them of course.

boyofgreen commented 8 years ago

We are likely doing a small windows10 releaes next week, we can get the first change in that.

AmazingJaze commented 8 years ago

Is there still chance of a release this week?

ghost commented 7 years ago

We'll be including this fix in the next release