search

pwa-builder / PWABuilder-CLI

Node.js tool for App Generation
Other
1.63k stars 142 forks source link

trim whitespace on discription and name #247

Closed boyofgreen closed 7 years ago

boyofgreen commented 7 years ago

We might be doing this on name already, but we noticed a windows 10 considered the manifest incompatible because the description didn't end or start with a space. We need to trip the description and name if not already doing it there.

codepo8 commented 7 years ago

I take this one one

boyofgreen commented 7 years ago

thanks, you likely fine the fixes in these files: https://github.com/manifoldjs/manifoldjs-lib/tree/v1.2.0-development-pwabuilder/lib/manifestTools/manifestCreator/scrapers

codepo8 commented 7 years ago

These have been fixed and I sent pull requests

On 9 Feb 2017 9:36 p.m., "Jeff Burtoft" notifications@github.com wrote:

Assigned #247 https://github.com/manifoldjs/ManifoldJS/issues/247 to @codepo8 https://github.com/codepo8.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/manifoldjs/ManifoldJS/issues/247#event-956356730, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA0xP9x7Iv4_HyxvLxBIsRG1aHKzrfcks5ra4bGgaJpZM4L0dzt .

boyofgreen commented 7 years ago

yes sorry, I added your name to this while I was showing someone else how easy it was to add their name to an issue. I didn't think it would ping about it. Thanks for the PRs, I'm taking them in and running test cases tonight, but I don't forsee any issues with these changes :)