pwa-builder / PWABuilder-CLI

Node.js tool for App Generation
Other
1.63k stars 142 forks source link

Manifest validation fails after resolving the "display" W3C property #270

Closed ghost closed 7 years ago

ghost commented 7 years ago

When the builder is creating a manifest of a site and infers that the display is fullscreen, standalone or minimal-ui, it retrieves the value true instead which is an invalid value for display.

The builder then fails during the manifest validation stage with the following error:

[error] general : Manifest validation ERROR - No enum match for: true(member: /display)

This can be reproduced on the http://politiken.dk/ site

rnrneverdies commented 7 years ago

Fixed, will be available in the next major release.