Allow "Browser" as screen type in manifest

pwa-builder / PWABuilder-CLI

Node.js tool for App Generation

Other

1.63k stars 142 forks source link

Allow "Browser" as screen type in manifest #275

Closed boyofgreen closed 4 years ago

boyofgreen commented 7 years ago

As in the AirB&B site:

https://www.airbnb.com/

rnrneverdies commented 7 years ago

Hi @boyofgreen, the site's manifest does not comply the w3c manifest schema since the valid value is "browser" (note lowercase). I think there is no elegant solution on our side taking into account how this validation is currently implemented. Perhaps fixing the manifest in the website would be the proper way to go.

Thoughts?

marcoscaceres commented 7 years ago

Let me know if I should ping someone at Airbnb. I know a few people there

lencioni commented 7 years ago

I'll fix it on Airbnb. Gotta go now, but should be in production tomorrowish.

marcoscaceres commented 7 years ago

Yay!!!! Thanks @lencioni! ⭐️

boyofgreen commented 7 years ago

Thanks @marcoscaceres and @lencioni easiest fix ever!

lencioni commented 7 years ago

FYI this fix is heading to production for Airbnb right now.

davrous commented 4 years ago

Not an issue anymore on pwabuilder.com. Closing.