search

pwa-builder / PWABuilder-CLI

Node.js tool for App Generation
Other
1.63k stars 142 forks source link

background_color manifest setting not respected #295

Open comp615 opened 6 years ago

comp615 commented 6 years ago

Running yarn pwabuilder -- https://mobile.twitter.com -l debug -p windows10

the output manifest.json has "background_color": "transparent"

However, at https://mobile.twitter.com/manifest.json you can see that it has "background_color":"#ffffff"

I'd expect that user specification to be maintained when supplied (since I think it's used to generate the windows 10 splash background)

boyofgreen commented 6 years ago

I'll look into this. It should be maintained for sure.

boyofgreen commented 6 years ago

I think i found the issue, and should be pretty easy to change. In the meantime, if you would like a work around, you can find the file in this dir: PWA\Store packages\windows10\manifest called "appxmanifest.xml" and edit this value it will change it. This will fix it for sideloading and appx generation. I should have this code reviewed and out in a few days.

comp615 commented 6 years ago

I think you probably want it as background color on uap:SplashScreen right? Although VisualElements can work too, that's for icons and tiles so might not be as direct a translation

boyofgreen commented 6 years ago

So if you put it on the VisualElements tag then it will effect the tile and splash screen both, unless you also define splash screen background color then it will override what is in Visual Elements. So if you only want to alter the splashscreen color then yes. Thanks for the clarification.