search

pwa-builder / PWABuilder-CLI

Node.js tool for App Generation
Other
1.63k stars 142 forks source link

Certain Images sizes not generated when image provided #296

Open comp615 opened 6 years ago

comp615 commented 6 years ago

When generating my app, I provided an image using the -i myImage.png flag. It's a 400x400 png.

Upon generation -p win10, I found that Square44x44Logo.scale-100.png was still the default PWA logo. I also see an entry in the logs: Removing missing images not found in the downloaded assets: Square150x150Logo.scale-100.png,Square44x44Logo.scale-100.png,StoreLogo.scale-100.png,SplashScreen.scale-100.png,SplashScreen.scale-200.png,Square150x150Logo.scale-200.png,Square44x44Logo.scale-200.png

I'm not sure why that's happening, but seems like a bug as I assume the image converter is properly downloading everything in the zip and this consistently repros.

boyofgreen commented 6 years ago

closing as we solved offline

comp615 commented 6 years ago

The offline issue we discussed was unrelated to this (where I wanted to mix-and-match). This issue is still valid for the normal workflow.

boyofgreen commented 6 years ago

okay, and this was on mobile.twitter.com? And latest version of PWABuilder?

boyofgreen commented 6 years ago

oh, nevermind, I see a local image. I'll take a look.