search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.66k stars 280 forks source link

Manifest is declared but getting "Couldn't find an app manifest." error on inspection #1131

Closed ParshuramPatil closed 3 years ago

ParshuramPatil commented 3 years ago

Describe the bug Getting "Couldn't find an app manifest." error on inspection. App URL: https://parshurampatil.com/tools/fintrak/ Manifest URL: https://parshurampatil.com/tools/fintrak/manifest.json

Edge/Chrome is able to find the manifest but the PWABuilder is not.

Expected behavior PWABuilder should be able to find app manifest

Screenshots image

Additional info (please complete the following information):

ghost commented 3 years ago

Hello ParshuramPatil, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

jgw96 commented 3 years ago

Thanks for opening an issue with us, I am goig to be looking into this today.

jgw96 commented 3 years ago

Manifest detection issue is fixed here https://github.com/pwa-builder/PWABuilder/tree/manifestFix but this uncovered a race condition farther on in the code. I am going to fix that first before closing this.

ParshuramPatil commented 3 years ago

Thanks Justin. Will test & confirm from my side once its closed.

rajsite commented 3 years ago

I also get the "Couldn't find an app manifest." error with my PWA and am curious if it is resolved by this PR as well or if I should open a new issue:

App URL: https://hosting.systemlinkcloud.io/webapps/57932453-f5ae-4ff3-a8a9-6eb5238f441b/content/ni-paths-NISHAREDDIR64/Web%20Server/htdocs/WebApp/index.html

Mainfest URL: https://hosting.systemlinkcloud.io/webapps/57932453-f5ae-4ff3-a8a9-6eb5238f441b/content/ni-paths-NISHAREDDIR64/Web%20Server/htdocs/WebApp/ProgressiveWebApp/Manifest/manifest.webmanifest.js

As-is the manifest is found by Chrome, Firefox, and iOS Safari.

jgw96 commented 3 years ago

@rajsite Thanks for sharing your URL! I can confirm that it works with the latest fix in preview, that will be deployed very soon to production! We ran into a few other things we wanted to get done before we released, but we are super close!

JudahGabriel commented 3 years ago

I've just checked the original poster's URL with the new release this morning. It doesn't work: the HTML parse manifest detection works, however, the sync with Redis code fails; POSTing the manifest to the API fails.

@lee-leonardo Can you have a look?

JudahGabriel commented 3 years ago

@lee-leonardo Also, the 2nd poster's URL has a similar issue: manifest detection succeeds, then it tries to sync with Redis and it times out.

JudahGabriel commented 3 years ago

OK @ParshuramPatil your URL is now fixed: https://parshurampatil.com/tools/fintrak/ Please give it a try and let me know.

JudahGabriel commented 3 years ago

@rajsite I'm glad to report that your URL works now in PWABuilder; your manifest is properly detected. Give it a try!

rajsite commented 3 years ago

@JudahGabriel it looks like pwabuilder can find the manifest files now! Thanks!

ParshuramPatil commented 3 years ago

OK @ParshuramPatil your URL is now fixed: https://parshurampatil.com/tools/fintrak/ Please give it a try and let me know.

Works now, Thanks!