search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.73k stars 283 forks source link

Error uploading windows10 new package to windows store #1181

Closed glalloue closed 3 years ago

glalloue commented 3 years ago

Describe the bug I tried to generate Windows 10 package with the preview of the New Edge platform Everything worked fine during the generation and I downloaded my packages well ! But when i upload .appxbundle and .msixbundle files to the Microsoft Store, I receive these errors :

Geoffrey Lallou_.classic.appxbundle399.4 KB Package acceptance validation warning : The following restricted capabilities require approval before you can use them in your app: runFullTrust.

Geoffrey Lallou_.msixbundle284.2 KB Package acceptance validation error : The PublisherDisplayName element in the app manifest of 26446GeoffreyLallou.GeoffreyLallou_1.0.1.0.msix is Microsoft Corporation, which doesn't match your publisher display name: Geoffrey Lalloué.

Package acceptance validation warning : The following restricted capabilities require approval before you can use them in your app: runFullTrust.

About warnings : i don't know what does that mean. But the error seems to come from the fact that the "Publisher name" information uses the default value and not the value I filled in :

image

URL to app https://geoffrey.lalloue.fr/

To Reproduce Steps to reproduce the behavior:

  1. Generate Windows 1O package with the preview of the New Edge platform
  2. Upload .appxbundle and .msixbundle files to the Microsoft Store.
  3. See errors

Expected behavior Microsoft store say everything is ok

Screenshots If applicable, add screenshots to help explain your problem. image

Additional info (please complete the following information):

Additional context I generate with the preview of the New Edge platform beceause of this issue : https://github.com/pwa-builder/PWABuilder/issues/1120

ghost commented 3 years ago

Hello glalloue, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

davrous commented 3 years ago

Hello! Thanks for reporting the issue. Adding @JudahGabriel and @jgw96 for visibility.

I've just tested on production (www.pwabuilder.com) and I'm not reproducing the issue. Can you please have a look to my detailed tutorial video: https://www.youtube.com/watch?v=ig78lT6SlNI and check if you haven't missed something?

Can you please also unzip the .msixbundle and give us a screenshot of the file under /AppxMetadata/AppxBundleManifest.xml? Please also unzip the .msix file inside the .msixbundle and share a screenshot of AppxManifest.xml.

FullTrust warning is normal as we're using a new Hosted App model approach to package the PWA which requires Full Trust capabilities. We're mentioning that in the doc: https://github.com/pwa-builder/pwabuilder-windows-chromium-docs/blob/master/publish-new-app.md but should probably be more explicit.

glalloue commented 3 years ago

Hi @davrous I saw your video (great turorial ;) ) I don't think i forgot something compared to your video.

I tried again to fill form on PWABuilder making attention on it and i generated new package, but i received the same error.

Here is the information you asked me :

/AppxMetadata/AppxBundleManifest.xml : image

26446GeoffreyLallou.GeoffreyLallou_1.0.1.0.msix/AppxManifest.xml : image

I think error is from here : "PublisherDisplayName" have "Microsoft Corporation" value

davrous commented 3 years ago

Thanks, it's really strange, I'm going to do further testing. You've got a special French character in your name, maybe it generates a fail in our code (this would be a pity but you never know ;)).

davrous commented 3 years ago

Ok, I've reproduced the issue using your name "Geoffrey Lalloué" in the Publisher Display Name. I'm almost sure it's coming from the "é". Sorry for that.

@JudahGabriel: there's probably an exception because of this character which then rollback to the default value. We're probably not handling Unicode correctly somewhere. We may face the same issue without other languages.

glalloue commented 3 years ago

What an idea to put accents everywhere in French names ! 🤪

I think I saw that you use external url to generate windows 10 package, so can you fix it or do i have to contact another team / someone to fix external windows 10 generation tool ?

davrous commented 3 years ago

We're working with the Edge team on the tooling. We'll first check if the issue doesn't come from our side before asking Edge to check their own code.

JudahGabriel commented 3 years ago

Hey @glalloue I'm checking with the Edge team to see if the bug is in their tooling. I'll get back to you shortly.

JudahGabriel commented 3 years ago

Update: The Edge team found that the XML serialization library they were using didn't properly handle unicode characters. I'm glad to report they've issued a PR to fix this. This fix should be available in PWABuilder in the next day or two. I'll post here when it's available.

JudahGabriel commented 3 years ago

The Edge team has sent me an updated package that handles unicode properly. I'm testing this today and if all is well, we should have a new deployment available.

JudahGabriel commented 3 years ago

Hey @glalloue I'm glad to report the Edge team has fixed this. I tested the fix and it seems to work great for your app, so it's deployed to pwabuilder.com.

I tested your URL with your display name (the accented é) - and your package was built with the correct display name. This means, you should be able to upload your app to the Microsoft Store without any trouble. 😎

Go ahead and give it a try and let us know how it goes.

glalloue commented 3 years ago

Everything went well, from package generation to the upload. No errors on Microsoft Partner Center, only classical warnings image

thank you so much. We can close this ticket