search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.69k stars 282 forks source link

Pwabuilder does not see my manifest #2102

Closed Veart79 closed 2 years ago

Veart79 commented 2 years ago

Hello! Pwabuilder does not detect my manifest. I have an vuejs PWA application .

pwa: https://test01.poliglotiki.ru/home-teacher manifest: https://test01.poliglotiki.ru/home-teacher/manifest.json Chrome detect my manifest correctly: image

I found what pwabuilder searching manifest at https://test01.poliglotiki.ru/home-teacher/home-teacher/manifest.json (double /home-teacher/). In my index i have base tag <base href=/home-teacher/> and manifest link <link rel=manifest href=/home-teacher/manifest.json>. Pwabuilder join base path and manifest href inspite of that manifest path is not relative. I think you don't need add base path to manifest path if it begins with root slash. When I remove base path or change manifest path to relative it work correctly. Unfortunnely I can't set this path in my app manually because of pwa plugin which generate it automatically.

ghost commented 2 years ago

Hello Veart79, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

JudahGabriel commented 2 years ago

Your site is working right now in PWABuilder. Are you seeing it not work?

Veart79 commented 2 years ago

It's works because I fixed link to manifest manually to relative path. If you need to see the bug I can turn it back.

Veart79 commented 2 years ago

It doesn't work with next lines in my index.html:

<base href=/home-teacher/> 
<link rel=manifest href=/home-teacher/manifest.json>

I've changed it back right now. Try again.

Veart79 commented 2 years ago

In debugger I see that manifest path is wrong: image

When I remove base path or change manifest path to relative it work correctly. My path to manifest is root-relative (it begins with slash) and I think you shouldn't add base path to it.

JudahGabriel commented 2 years ago

@veart79 Got it. I've deployed a fix for this so that we now resolve the manifest in a smarter way. Can you revert your website to use the following:

<base href=/home-teacher/> 
<link rel=manifest href=/home-teacher/manifest.json>

? Please use that and PWABuilder should detect it.

JudahGabriel commented 2 years ago

Now that the fix is deployed, I'm closing this issue. Please reopen if you continue to experience problems.