search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.75k stars 284 forks source link

Error generating windows package #2126

Closed thomasgrundydiscovery closed 3 years ago

thomasgrundydiscovery commented 3 years ago

I received the following error when generating a package for https://www.discoveryplus.com/tabbed-home

Error: Error generating Windows package Error: Failed. Status code 500, Error: Internal Server Error, Details: Microsoft.PWABuilder.Windows.Chromium.Models.ProcessException: The makeappx.exe process exited with exit code 1.

Process: C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\makeappx.exe

Process args: pack /o /d "D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\appx-unzipped" /p "D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\9c5a77bd-74ba-4e27-bb02-420f68ec2f6e.appx"

Standard output: Microsoft (R) MakeAppx Tool

Copyright (C) 2013 Microsoft. All rights reserved.

The path (/p) parameter is: "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\9c5a77bd-74ba-4e27-bb02-420f68ec2f6e.appx"

The content directory (/d) parameter is: "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\appx-unzipped"

Enumerating files from directory "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\appx-unzipped"

Packing 85 file(s) in "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\appx-unzipped" (content directory) to "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\9c5a77bd-74ba-4e27-bb02-420f68ec2f6e.appx" (output file name).

Memory limit defaulting to 4294414336 bytes.

Using "\?\D:\Temp\pwabuilder\classic-package-48bde06d-ca75-4854-856e-2b77be5ea03e\appx-unzipped\AppxManifest.xml" as the manifest for the package.

MakeAppx : error: Error info: error C00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 25, Column 52, Reason: 'Introducing discovery+, the only streaming service with the greatest real-life entertainment from your favorite TV brands - including HGTV, Food Network, TLC, ID, Animal Planet, Discovery Channel - and personalities, plus exclusive originals, all in one place. Whatever you?re into, you?ll find it here. Start

ghost commented 3 years ago

Hello thomasgrundydiscovery, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

jgw96 commented 3 years ago

Hello @thomasgrundydiscovery ! I have shared this with @JudahGabriel and we are discussing it on our end. We will update this issue when we have more info.

jgw96 commented 3 years ago

It looks like this may be the package generator having a problem with the + character in the description field of your manifest, but we will update again when we know for sure.

JudahGabriel commented 3 years ago

Hi @thomasgrundydiscovery

The issue is that your web manifest's description contained new line characters and was longer than 2048 in length. Windows packages don't allow for that.

I've updated our code so that the internal package description strips out new line characters (replacing them with space), and clips the text to 2045 + "...".

You can still have your real app description when you upload the package to Partner Center. The description in the app package isn't currently used.

Bottom line: this is fixed, please repackage with PWABuilder and it should work for you. Give it a try?

thomasgrundydiscovery commented 3 years ago

Thank you so much for resolving this!

davrous commented 3 years ago

Looks like we can close this issue then. Thanks everybody!