search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.69k stars 282 forks source link

PWA does not get taken to the publish page #2174

Closed tlhunter closed 2 years ago

tlhunter commented 2 years ago

Is your feature request related to a problem? Please describe. I'm going through the PWA Builder wizard with an existing, working PWA of mine (https://app.radar.chat):

2021-11-01_15-02-48

These results suggest that the PWA is good. It does work fine on Android and iOS browser via add to homescreen, and already has a manifest and service worker. So I click the Next button.

The next screen seems to suggest that I need to add a manifest file and a service worker. It links to the [https://github.com/pwa-builder/pwabuilder-web/blob/V2/src/assets/next-steps.md](next steps) markdown document telling me to add a bunch of files, and reference them in the HTML. It also mentions a pwabuilder-sw.js file, though it doesn't seem to be available for download.

The Generate button gives me a zip file with a manifest.json file that is the same as the one I already have except that the icon paths are different (using images/ in the root). It doesn't contain a pwabuilder-sw.js file.

Describe the solution you'd like I'd like it if the docs mention exactly what the requirements are for PWA Builder to generate a native app project. Like, do I need to move the icons to a /images/ folder? Do I need to rename my existing service-worker.js file to pwabuilder-sw.js? The current docs seem mostly targeted towards developers who don't yet have a PWA.

Describe alternatives you've considered N/A

Additional context N/A

ghost commented 2 years ago

Thanks for submitting a new feature request! I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future.

jgw96 commented 2 years ago

Hey @tlhunter , unfortunately im unable to reproduce this issue. What is the exact URL you are putting into the input on the home page?

tlhunter commented 2 years ago

@jgw96

https://app.radar.chat

tlhunter commented 2 years ago

I opened PWA Builder using a Firefox private window and the build was able to work.