pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.69k stars 282 forks source link

Error generating windows package #2213

Closed adinastoll closed 2 years ago

adinastoll commented 2 years ago

I received the following error when generating a package for https://businesscentral.dynamics.com/pwa

Error: Error generating Windows package Error: Failed. Status code 500, Error: , Details: Microsoft.PWABuilder.Windows.Chromium.Models.ProcessException: The pwa_builder.exe process exited with exit code 1.

Process: C:\inetpub\wwwroot\Resources\cli\pwabuilder\pwa_builder.exe

Process args: --url="https://businesscentral.dynamics.com/pwa" --target="D:\Temp\pwabuilder\modernpackage-47add80c-ffec-4ed3-993e-ace134488092" --version="1.0.1.0" --publisher="Microsoft Corporation" --package-id-name="Microsoft.ProjectMadeira" --launch-args=" --windows-store-app" --display-name="BusinessCentral" --publisher-display-name="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" --images="D:\Temp\pwabuilder\app-images-92c55244-741a-4bf5-9f52-732c60e65389" --pri="C:\inetpub\wwwroot\Resources\resources.pri" --resource-language="EN-US" --display-mode="standalone" --signed-app

Standard output:

Standard error: [1112/115900.765:WARNING:resource_bundle.cc(482)] locale_file_path.empty() for locale [1112/115901.547:INFO:pwa_headless_manifest_handler.cc(205)] Found manifest at https://businesscentral.dynamics.com/manifest.webmanifest [1112/115902.759:ERROR:appx_package_builder.cc(259)] packageWriter->Close(manifestStream.Get()) failed, hr=0x80080204 [1112/115902.759:ERROR:pwa_package_builder.cc(128)] Package creation failed.

Output directory: D:\Temp\pwabuilder\modernpackage-47add80c-ffec-4ed3-993e-ace134488092

Msix options: --url="https://businesscentral.dynamics.com/pwa" --target="D:\Temp\pwabuilder\modernpackage-47add80c-ffec-4ed3-993e-ace134488092" --version="1.0.1.0" --publisher="Microsoft Corporation" --package-id-name="Microsoft.ProjectMadeira" --launch-args=" --windows-store-app" --display-name="BusinessCentral" --publisher-display-name="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" --images="D:\Temp\pwabuilder\app-images-92c55244-741a-4bf5-9f52-732c60e65389" --pri="C:\inetpub\wwwroot\Resources\res

ghost commented 2 years ago

Hello AdinaNgr, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

JudahGabriel commented 2 years ago

Hey @AdinaNgr

I think you have your values mixed up in the PWABuilder form.

Make sure Publisher ID is set to the CN=... value. (In your case, you set the Publisher Display Name to that value, which probably caused the problem.)

Also, are you sure your Publisher ID is CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US? I think it's wrong. Usually it's a GUID, e.g. CN=5da8e99b-3680-4bba-89fa-f6efed62ae45.

You can find your publisher values here: https://blog.pwabuilder.com/docs/finding-your-windows-publisher-info/ - you'll need them when you upload your app to Partner Center.

p.s. I'm on Teams, Judah Himango, if you need to chat.

JudahGabriel commented 2 years ago

Also noticed we had a small bug around spaces in app names. That's fixed with PR: https://github.com/pwa-builder/PWABuilder/pull/2214

adinastoll commented 2 years ago

Great! Thanks. I could package it now with the right Publisher ID.

But the name still can't contain spaces. - Do you know when the fix will be deployed for that?

JudahGabriel commented 2 years ago

Will be deployed today.

JudahGabriel commented 2 years ago

@AdinaNgr The fix for spaces in app name has been deployed. Feel free to reopen this issue if you're still having trouble.