search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.77k stars 285 forks source link

In the manifest.json doesn't allow the display to be set to "browser". #2420

Closed thebuddhaswords closed 2 years ago

thebuddhaswords commented 2 years ago

I'd prefer the PWA on https://thebuddhaswords.net to look and behave like a browser as I have internal links which are designed to be opened in a new browser tab. However, when the display in manifest.json is set to "browser", it is ignored and I get the error message "Manifest 'display' property must be one of 'standalone', 'fullscreen' or 'minimal-ui'". Leaving the display field blank or omitting the field entirely produces the same error message. According to the documentation, the display should fall back to "browser" if other displays are not specified.

Thanks for looking into this.

ghost commented 2 years ago

Hello thebuddhaswords, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

jgw96 commented 2 years ago

@thebuddhaswords Where are you getting this error message?

thebuddhaswords commented 2 years ago

Hi Justin, thanks for getting back to me. I get the error in the Application | Manifest section of Dev Tools on Chrome for Windows version 97.0.4.4692.71 I’ve included a screenshot All the best Tom   From: Justin WillisSent: Thursday, 13 January 2022 6:01 AMTo: pwa-builder/PWABuilderCc: thebuddhaswords; MentionSubject: Re: [pwa-builder/PWABuilder] In the manifest.json doesn't allow the display to be set to "browser". (Issue @.*** Where are you getting this error message?—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

thebuddhaswords commented 2 years ago

bw2screenshot

thebuddhaswords commented 2 years ago

According to the PWA builder, "browser" is one of the valid options for display. bw2screenshot2 The w3.org specification supports the "browser" option. In the original support request I referred to the progressive fallback behaviour when a particular display mode is unavailable. The specifications for that and the list of display modes can be found at https://www.w3.org/TR/appmanifest/#dfn-display-modes-list

bw2screenshot3

Thanks again

Tom

nmetulev commented 2 years ago

Hi there, setting your display property to browser indicated that your app should not be installable and should always run in the browser.