search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.69k stars 282 forks source link

VSCode Extension: Failing to Identify Service Worker in GUI #2513

Closed zateutsch closed 2 years ago

zateutsch commented 2 years ago

Describe the bug ServiceWorker not being found after cloning PWA, clicking "I have a service worker" and identifying the file still shows "No Service Worker found".

To Reproduce Steps to reproduce the behavior:

  1. Clone the PWA Starter with the Code extension command.
  2. Navigate to PWA Tab
  3. See "No Service Worker found"
  4. Click "I Have a Service Worker"
  5. Identify file.
  6. No update in PWA GUI.

Expected behavior Service Worker is found on clone of PWA Starter repository. If not, selecting service worker file updates the GUI.

Screenshots image

Additional info (please complete the following information):

Additional context The store ready checklist is showing Service Worker as "true." Perhaps this is just a problem with the GUI flow?

ghost commented 2 years ago

Hello zateutsch, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

jgw96 commented 2 years ago

Hey @zateutsch I am unfortunately unable to reproduce this issue. My steps were:

Am I missing a step?

zateutsch commented 2 years ago

Nope. Exact same. I'll try running thru the steps again and see if it happens again.

zateutsch commented 2 years ago

Still getting the same problem on second time through. Going to pivot away from this for a second because it seems to be a problem on my end, I'll look into the cause later.

jgw96 commented 2 years ago

Meeting with @zateutsch this afternoon about docs and this issue.