vscode: The diagnostics will cause the manifest view to fail

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.

https://docs.pwabuilder.com

Other

2.7k stars 280 forks source link

vscode: The diagnostics will cause the manifest view to fail #2555

Closed jgw96 closed 2 years ago

jgw96 commented 2 years ago

The manifest and service worker view panels would sometimes not be able to complete the tests, leaving them empty.

The reason was:

Diagnostics were trying to fun on non JSON files. When are tests then tried to run, they would fail on non valid JSON tokens as we were trying to JSON.parse() any values, not just JSON files.

ghost commented 2 years ago

Hello jgw96, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

jgw96 commented 2 years ago

Fixed with https://github.com/pwa-builder/pwabuilder-vscode/actions/runs/1775666072