search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.75k stars 284 forks source link

PWA Studio - leverage product icons for view actions #2564

Closed miguelsolorio closed 2 years ago

miguelsolorio commented 2 years ago

Noticed that the extension is using a lot of custom icons:

https://github.com/pwa-builder/pwabuilder-vscode/tree/main/resources

VS Code has a built-in product icon library that extensions can leverage without needing to create additional assets. This means it can reduce your assets and make the app a little lighter.

CleanShot 2022-02-01 at 17 15 49@2x

Let me know if this is something you'd like to see a PR for and I'd be happy to contribute!

ghost commented 2 years ago

Thanks for submitting a new feature request! I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future.

jgw96 commented 2 years ago

@misolori Id love to see a PR! I very very much appreciate all the feedback. Feel free to ping me here (or on Teams) if you have any questions and when the PR is ready.

jgw96 commented 2 years ago

Assigning you to this along with myself just to keep track for myself 😊

miguelsolorio commented 2 years ago

@jgw96 PR ready for your review https://github.com/pwa-builder/pwabuilder-vscode/pull/53