search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.78k stars 287 forks source link

Error generating android package #3277

Closed drprime1z closed 2 years ago

drprime1z commented 2 years ago

I received the following error when generating a package for https://myapp.smartinfraco.com

Error: Error generating Android package. Status code: 500 Error: Internal Server Error Details: Error generating app package: Failed to download icon https://myapp.smartinfraco.com/undefined. Responded with status 404 stack: Error: Failed to download icon https://myapp.smartinfraco.com/undefined. Responded with status 404 at ImageHelper.fetchIcon (/app/node_modules/@bubblewrap/core/dist/lib/ImageHelper.js:95:19) at processTicksAndRejections (internal/process/task_queues.js:97:5) at TwaGenerator.generateIcons (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:210:22) at async Promise.all (index 1) at TwaGenerator.generateShortcuts (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:242:9) at TwaGenerator.createTwaProject (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:335:9) at BubbleWrapper.generateTwaProject (/app/build/bubbleWrapper.ts:112:9) at BubbleWrapper.generateAppPackage (/app/build/bubbleWrapper.ts:53:9) at createAppPackageWith403Fallback (/app/routes/project.ts:249:12) at createAppPackage (/app/routes/project.ts:225:12)

Jaylyn-Barbee commented 2 years ago

In your manifest shortcuts field, you have an empty list nested within one of your icons arrays.

{
  "name": "SignUp",
  "description": "SignUp on MySI",
  "url": "\/register",
  "icons": [
      []
  ]
}

To prevent this error from happening, you can just remove that empty nested list.

drprime1z commented 2 years ago

Thanks for Ponting this out but it was not empty but it just was not there at the first place so I think logically its adding it. will update and the code and test again thanks for your feedback.