[BUG] Youtube has no icon on the report card page

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.

https://docs.pwabuilder.com

Other

2.69k stars 282 forks source link

[BUG] Youtube has no icon on the report card page #4188

Open nmetulev opened 1 year ago

nmetulev commented 1 year ago

What happened?

How do we reproduce the behavior?

Use youtube.com for testing on pwabuilder.com

What do you expect to happen?

No response

What environment were you using?

Edge

Additional context

No response

Jaylyn-Barbee commented 1 year ago

Youtube does have an icon on the report card page... it's just white... https://www.gstatic.com/youtube/img/web/monochrome/logo_512x512.png It is listed as monochrome so maybe we ignore these types of icons? we should talk about how to handle this though.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

beth-panx commented 1 year ago

I think monochrome and maskable icons are for specific purposes. I propose we update the logic to use purpose: any or no purpose field. Of course, if the 512x512 doesn't exist in that context, use the largest one.

Reference: icon manifest def