pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.77k stars 285 forks source link

[PWA Builder]: Whole dialogue get closed when we press 'Esc' key to close the info icon pop-up. #4262

Open Anshi0420 opened 1 year ago

Anshi0420 commented 1 year ago

What happened?

When we press the 'Esc' key to close the info icon pop-up the whole 'Edit your Manifest' Dialogue get closed.

How do we reproduce the behavior?

Repro Steps:

  1. Open the PWA Builder URL in Anaheim dev browser.
  2. PWA Builder page will appear.
  3. Navigate to the 'Edit your Manifest' button activate it.
  4. Navigate to the info icon and activate it with enter.
  5. Pop-up will appear now press 'Esc' key to close the pop-up.
  6. Observe the issue.

What do you expect to happen?

Whole dialogue must not get closed only the info icon pop-up must get closed when the user activates 'esc' key.

What environment were you using?

Test Environment: OS Build: Windows 11 Enterprise Insider Preview 22H2 (23493.1000) Edge Browser: Version 115.0.1880.3 (Official build) dev (64-bit) User ID: V- URL: https://www.pwabuilder.com/reportcard?site=https://webboard.app

Additional context

Note: Issue is also repro at https://www.pwabuilder.com/reportcard?site=https://example.com

User Experience: If the whole dialogue will get close instead of pop-up then keyboard users will face difficulty in accessing the UI they need to navigate again the whole steps to reach to the content.

WCAG Reference: https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

Attachments:

https://github.com/pwa-builder/PWABuilder/assets/117908911/564eba78-daad-4ab3-b73f-ef116476426d

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 12 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 11 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 11 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 11 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 11 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 10 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 10 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 10 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 10 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 9 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 8 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 8 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 8 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 7 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 7 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 7 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 6 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 6 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 6 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 6 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 5 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 5 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 5 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 5 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 4 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 4 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 4 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .