Closed steelbrain closed 6 months ago
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
This issue has been marked as "needs attention š" since it has not been triaged for 7 days. Please triage the issue .
What happened?
In iOS, we match the host origin first (https://github.com/pwa-builder/pwabuilder-ios/blob/209972b1286f37e7846887521e6c9c61404e74ab/Microsoft.PWABuilder.IOS.Web/Resources/ios-project-src/pwa-shell/WebView.swift#L104C1-L104C1) and then we match the auth origin (https://github.com/pwa-builder/pwabuilder-ios/blob/209972b1286f37e7846887521e6c9c61404e74ab/Microsoft.PWABuilder.IOS.Web/Resources/ios-project-src/pwa-shell/WebView.swift#L114).
This is erroneous behavior because if auth origin is
auth.pwabuilder.com
and host origin ispwabuilder.com
, then even if you go to auth subdomain, the first check will keep on triggering and it'll not even check for auth origin so users will not get the nice "done" button and ability to abort auth process.How do we reproduce the behavior?
What do you expect to happen?
I expect to see the done bottom up top and ability to abort the process.
What environment were you using?
iOS 17, Emulator for iPhone 15 Pro
Additional context
No response