pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.66k stars 279 forks source link

Transparent new default for Windows Icon Backgrounds. #4571

Closed Jaylyn-Barbee closed 8 months ago

Jaylyn-Barbee commented 8 months ago

fixes https://github.com/pwa-builder/PWABuilder/issues/4401

PR Type

Feature

Describe the current behavior?

Manifest background color is default for icon background

Describe the new behavior?

Transparent is default for icon background

PR Checklist

Additional Information

This PR also disables the ability to generate screenshots as we feel generating base64 strings into peoples manifest is creating an inefficient system and people don't understand why its inefficient and trusting that PWABuilder is doing the right thing when it isn't. Part of the temporary solution described here https://github.com/pwa-builder/PWABuilder/issues/4550

microsoft-github-policy-service[bot] commented 8 months ago

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4571.centralus.2.azurestaticapps.net