search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.55k stars 273 forks source link

[BUG] Clicking 'No' under "Did you add your manifest" results in no action #4614

Closed zateutsch closed 4 months ago

zateutsch commented 6 months ago

What happened?

If you edit your manifest and then click the notification under action items, the dialogue that opens has a "No" button that does nothing.

image

How do we reproduce the behavior?

  1. Test site on PWABuilder.
  2. Open manifest editor and make any change to manifest.
  3. Close editor.
  4. Click retest notification under action items that appears.
  5. Click 'No' when prompted.
  6. Nothing happens.

What do you expect to happen?

When the user clicks no, a dialogue should appear that reminds them to add their new manifest before trying to retest.

What environment were you using?

OS: Windows 11 Browser: Edge

Additional context

I'll take this.