pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.54k stars 273 forks source link

[BUG] Apple Login Does Not Work Correctly [Video Included!] #4677

Closed AminDhouib closed 3 months ago

AminDhouib commented 4 months ago

Here is our pwa config:

import pwa from 'next-pwa'

...
...

const withPWA = pwa({
    dest: 'public',
    runtimeCaching: [
        {
            urlPattern: /\/api\/auth\/.*/,
            handler: 'NetworkOnly',
            options: {},
        },
    ],
})

The Issue

Google login does not work correctly for the iOS PWA of unotes. I have attached a video below that shows the issue.

I have extensively added all of these app-bound domains (WKAppBoundDomains) in the build on Xcode:

accounts.google.com
accounts.youtube.com
appleid.apple.com

But that did not fix it.

How do we reproduce the behavior?

https://github.com/pwa-builder/PWABuilder/assets/43147238/0c76e366-17e4-4b46-b192-607331fb10ee

What do you expect to happen?

Clicking Google sign in should allow user to login using Google then it should redirect to the app. Exactly how it works if you attempt to run it through the web version of the website or even on the Android app on Google Play Store.

https://github.com/pwa-builder/PWABuilder/assets/43147238/67f65078-b960-40b0-9400-4414ceadfe40

What environment were you using?

Issue happens when using iOS phones (tested on iPhone 12, iPhone 14, SE 2020). Issue also happens on simulated iPhone 14 on XCode. Though, can assume that all of this does not work correctly on every iOS.

Additional context

ghleoperez commented 3 months ago

Hi, this is Leo, Please add "apple.com", as well git

jgw96 commented 3 months ago

Closing this one for now as we handle iOS platform issues through our Discord https://aka.ms/pwabuilderdiscord