pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.54k stars 273 forks source link

[BUG] Special characters in app name causes problems with pod install #4710

Open rndfm opened 2 months ago

rndfm commented 2 months ago

What happened?

I tried packaging and app named Strømligning for Apple App Store.

When running the pod install command I get the following error:

Nanaimo::Reader::ParseError - [!] Dictionary missing ';' after key-value pair for "path", found "\xC3"
  #  -------------------------------------------
  #         4C1C2162A8048FDF52B2A9D0 /* Pods-Strømligning.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Strømligning.release.xcconfig"; path = "Target Support Files/Pods-Strømligning/Pods-Strømligning.release.xcconfig"; sourceTree = "<group>"; };
  #  
55>         59333BAA25CFF706003392A4 /* Strømligning.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Strømligning.app; sourceTree = BUILT_PRODUCTS_DIR; };
                                                                                                                                                             ^
  #         595F239A25CEFBFD0053416C /* Settings.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = Settings.swift; path = "Strømligning/Settings.swift"; sourceTree = "<group>"; };
  #  -------------------------------------------

It seems to be a problem with the character ø in the Strømligning.app

The Bundle id is transformed to: dk.stromligning Maybe Strømligning.app should too.

How do we reproduce the behavior?

Create a package for an app with an ø in it. Try to run pod install

What do you expect to happen?

I would expect the id where somehow valid and the pod install would work.

What environment were you using?

OS: Mac Sonoma 14.4.1 (23E224)

Additional context

No response

jgw96 commented 2 months ago

@rndfm I need to ask our iOS person some questions around this issue to understand any potential fix more, however in the meantime our Discord https://discord.com/invite/hXGv6HvtrK is where we do most of our support for the iOS platform.

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 weeks ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 weeks ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 week ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 days ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .