search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.54k stars 273 forks source link

[BUG] Report says "You do not have a secure HTTPS server" even though I have a valid SSL certificate #4721

Closed dave0688 closed 1 month ago

dave0688 commented 1 month ago

What happened?

Hi,

I want to package my PWA, and also the service worker is found. Please look at my report card here: https://www.pwabuilder.com/reportcard?site=https://dev.app.leafconnect.de/pwa

However, after a while it says "You do not have a secure HTTPS server". But my app has a valid certificate, as well as a working service worker.

Just for explanation: The url is https://dev.app.leafconnect.de/pwa (note the /pwa), because if you open the TLD, it automatically redirects to our login provider, which is an external OAuth2 provider (and thus doesn't have a service worker and manifest). Therefore we specifically made /pwa work without authentication.

Can anyone please help with that?

Thanks in advance :)

Best, David

image

How do we reproduce the behavior?

  1. Open the report of the app: https://www.pwabuilder.com/reportcard?site=https://dev.app.leafconnect.de/pwa -> You will see that, after like 10 seconds the message "You do not have a secure HTTPS server" appears

  2. Go to https://dev.app.leafconnect.de/pwa -> Here you see that the certificate is valid.

What do you expect to happen?

That we can package the app successfully.

What environment were you using?

MacOS

Additional context

No response

jgw96 commented 1 month ago

Hey! So when I go to this URL in my browser, it never seems to finish loading, can you confirm it actually loads on your end? On my side, I just get an empty screen.

dave0688 commented 1 month ago

Hey hey, Thanks for checking :) It is actually just a blank black screen, there's nothing on it. But the app is fully loaded and also the service worker is correctly initialized. So, everything should be up and running.

Best regards David

dave0688 commented 1 month ago

Any hint from anyone? Unfortunately we're completely blocked by that point :/ And we cannot find any reasonable explanation.

Edit: I'm also happy to debug the issue. Currently I'm stuck at the backend call. Is the code for that also in this repo?

image

Also hints for how to debug that issue are greatly appreciated - maybe a hint on where that piece of code is...

jgw96 commented 1 month ago

Hey! Sorry for the delay, let me ask a teammate to take a look at this as I dont have time unfortunately at the moment.

jgw96 commented 1 month ago

Hey @dave0688 , we are, kinda weirdly, actually unable to reproduce this issue. Would you mind trying again?

jgw96 commented 1 month ago

I appreciate the drive to debug yourself btw!

dave0688 commented 1 month ago

Hi, Thanks again for checking :) We have now changed the workflow a bit and implemented a "landingpage" (https://dev.app.leafconnect.de), which doesn't redirect to the login app.

By providing the TLD to PWABuilder now everything works and we can package the app :)

We figured out that it's very problematic to have the manifest.json in a sub-path (which was /pwa for us). There are solutions, but they involve many workarounds, like e.g. a server redirect from / to /pwa. To be honest we didn't even try that because the risk is quite high that there's still some things not working, so we went with the most straight-forward approach (leaving the manifest in the root).