pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.54k stars 273 forks source link

[BUG] Can't build Windows Package when changing the Classic Version #4732

Closed v38armageddon closed 1 month ago

v38armageddon commented 1 month ago

Link to the report card page

https://www.pwabuilder.com/reportcard?site=https://blog.v38armageddon.net

What Store were you trying to package for?

Windows

What is the error message you received?

image

Paste your stack trace below

The site I was testing is: https://blog.v38armageddon.net We@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:13:3036 je@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:14:7402 fe@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:14:7011 generate@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1833:1129 submitForm@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1914:144 renderFormFooter/<@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1902:76 handleEvent@https://www.pwabuilder.com/code/index.d23e9e02.js:15:6794

What environment were you using?

OS: Archlinux Browser: Firefox Version: 126.0.1

Additional context

I was building the package for a new version of my PWA app, I changed the following options when I was trying to build:

When I changed the Classic version to default value (1.0.0), it worked as expected.

EDIT: I was trying on only one browser, will add update with Microsoft Edge ASAP

jgw96 commented 1 month ago

Hey @v38armageddon , the classic version ALWAYS has to be lower than the App Version. The tooltip on that form input mentions this, along with our help page on this(https://blog.pwabuilder.com/docs/what-is-a-classic-package/), but the form does not error if the version is wrong. Ill take that on as a separate issue, but yeah, your app packages when the classic version is lower than the app version.