pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.8k stars 287 forks source link

Support new iOS icons configuration #4773

Open maiconcarraro opened 4 months ago

maiconcarraro commented 4 months ago

Tell us about your feature idea

iOS 18 gives us the ability to have a separate app icon for light mode, dark mode, and the new tinted option. More information on https://developer.apple.com/design/human-interface-guidelines/app-icons#Platform-considerations.

Do you have an implementation or a solution in mind?

It seems to require xcode 16 and update path_to_project/Assets.xcassets/AppIcon.appiconset/Contents.json to have a specific configuration, more information on https://medium.com/@jpmtech/get-your-app-icon-ready-for-ios-18-269d128c3a48

Which I believe must be updated here: https://github.com/pwa-builder/pwabuilder-ios/blob/main/Microsoft.PWABuilder.IOS.Web/Resources/ios-project-src/pwa-shell/Assets.xcassets/AppIcon.appiconset/Contents.json

Have you considered any alternatives?

I can manually change the assets and configuration, but would be nice to have this already done once we generate the package.

microsoft-github-policy-service[bot] commented 4 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

xnousnow commented 1 month ago

Any updates?

microsoft-github-policy-service[bot] commented 3 weeks ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 2 weeks ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 week ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .