pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.77k stars 287 forks source link

[BUG] Google Play Billing Library #4789

Closed EagleDotNet closed 1 month ago

EagleDotNet commented 2 months ago

What happened?

When uploading the application to Google Play, a warning appears due to using an old version of Google Play Billing Library and requests an update to version 6 or 7.

According to Google's timeline here , support for version 5 will end on Aug-31-2024.

How do we reproduce the behavior?

Error message appears after uploading the application to Google Play

What do you expect to happen?

Google Play Billing Library is updated to version 7.

What environment were you using?

Windows 10 with chrome

Additional context

No response

maiconcarraro commented 2 months ago

@EagleDotNet did you generate the package this week? the android package just got upgraded to sdk 35 including some updates to the billing around monday-tuesday, I generated a new app package and it has


<meta-data android:name="com.google.android.play.billingclient.version" android:value="6.2.1"/>`
maiconcarraro commented 2 months ago

I believe that a request to upgrade the billing to version 7 should be created on android-browser-helper as example of the version 6 upgrade few weeks ago: https://github.com/GoogleChrome/android-browser-helper/pull/476

EagleDotNet commented 2 months ago

@EagleDotNet did you generate the package this week? the android package just got upgraded to sdk 35 including some updates to the billing around monday-tuesday, I generated a new app package and it has

<meta-data android:name="com.google.android.play.billingclient.version" android:value="6.2.1"/>`

Indeed, when searching the source code, I found that the version used is 6.2.1, but the warning appears on the Google Play console page.

maiconcarraro commented 2 months ago

@EagleDotNet can you share more information about the warning? It may be related to an old bundle or apps in testing, and not really about your latest bundle, if you open the warning and go to "view app bundles" that are affected, it should link to the speciifc ones.

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

EagleDotNet commented 2 months ago

The warning disappeared yesterday even though I did nothing, this was different from the SDK warning which disappeared right away when I uploaded a new version.

microsoft-github-policy-service[bot] commented 2 months ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

microsoft-github-policy-service[bot] commented 1 month ago

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

maiconcarraro commented 1 month ago

@jgw96 you can close this