fix: app file input styling to better ux - Githubissues

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.

https://docs.pwabuilder.com

Other

2.71k stars 280 forks source link

fix: app file input styling to better ux #4794

Closed maiconcarraro closed 1 month ago

maiconcarraro commented 1 month ago

No opened issue, it was reported in discord: https://discord.com/channels/930156205542883409/1276973525546172478/1277006937396875497

PR Type

Bugfix

Describe the current behavior?

Existing app-file-input has no style which creates confusion with text elements, some elements are using class to specify variants instead of using the actual variant attribute.

Describe the new behavior?

Changes:

Updated app-file-input to use sl-button and variant secondary which seems a good fit for this situation.
Removed a cursor pointer styling that was misleading because of element's width
Updated primary button to fit the primary theme color.

PR Checklist

[X] Test: run npm run test and ensure that all tests pass
[X] Target main branch (or an appropriate release branch if appropriate for a bug fix)
[X] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

microsoft-github-policy-service[bot] commented 1 month ago

Thanks maiconcarraro for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌