pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.81k stars 287 forks source link

fix: playwright tests #4829

Closed maiconcarraro closed 1 month ago

maiconcarraro commented 1 month ago

PR Type

Describe the current behavior?

The existing npm run tests is using a hardcoded URL mapped to https://preview.pwabuilder.com/reportcard?site=https://webboard.app which isn't working (outdated env variable) and also doesn't help validate localhost.

Describe the new behavior?

Keep existing setup for CI, and allow localhost sanity check run for devs.

image

PR Checklist

Additional Information

microsoft-github-policy-service[bot] commented 1 month ago

Thanks maiconcarraro for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌