doc: replaced '<URL to your PWA>' by '<Host URL of your PWA>' in andr…

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.

https://docs.pwabuilder.com

Other

2.82k stars 287 forks source link

doc: replaced '<URL to your PWA>' by '<Host URL of your PWA>' in andr… #4833

Closed clementlize closed 3 weeks ago

clementlize commented 1 month ago

fixes #4832

PR Type

Documentation content changes

Describe the current behavior?

To properly deploy this file, upload it to your server at https://<URL to your PWA>/.well-known/assetlinks.json.

Describe the new behavior?

To properly deploy this file, upload it to your server at https://<Host URL of your PWA>/.well-known/assetlinks.json.

PR Checklist

[ ] Test: run npm run test and ensure that all tests pass
[ ] Target main branch (or an appropriate release branch if appropriate for a bug fix)
[ ] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

clementlize commented 1 month ago

Hi @jgw96

I don't think you're overthinking, it could be great to remind what's the host. To me it seemed obvious because I just built the PWA with the website and it specifically asks to split host and path, so I had it on my mind.

I'll take time this week to try and explain a bit in the md file

jgw96 commented 1 month ago

Sounds good! Let me know if you need any help etc 😊

clementlize commented 1 month ago

@jgw96 Hi there, I updated the PR with a better commit that

Removes https before <URL> (because protocol is part of the URL!)
Replaces <URL to your PWA> by <Host URL of your PWA> (1st intention of this PR)
Adds a note block explaining what is the Host URL with an example
Turns the Digital asset links are required for your PWA message from note to important block, because well it's very important to my mind and it renders better with the new note block just above

jgw96 commented 3 weeks ago

thank you!!!!!