search

pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.
https://docs.pwabuilder.com
Other
2.66k stars 279 forks source link

Followed all the steps but does not load #553

Closed thefandango closed 4 years ago

thefandango commented 4 years ago

I followed all the steps on pwabuilder, and the steps in the files.

So there is a mainfest, js, manup, all in root. Head links to scripts and manifest, but no pwa option in mobile.

Have also tested using lighthouse and it says not manifest available?

Site is feedmegames.com

Thanks

jgw96 commented 4 years ago

Hello! Thanks for opening an issue with us! Could you provide more info such as what your links to your serviec worker and manifest looks like? Also, did you add the registration code for your service worker too? Finally, if you could provide the exact steps you followed that would be very helpful for us to reproduce.

Thanks!

davrous commented 4 years ago

Hi! Your service worker is not registering properly, that's why you can't install on mobile as a complete PWA. In your SW, please update this line:

if (offlineFallbackPage === "https://feedmegames.com/static/offline") {

back to:

if (offlineFallbackPage === "ToDo-replace-this-name.html") {

David

thefandango commented 4 years ago

Hi

Thanks for your reply. I did that, and I still don't see the add to homescreen link appear when visiting the site. Using incognito tab as well.

I have added the calls in the header, I have uploaded the manifest, the js file, uploaded and called the manup js, and as far as I can see, have followed all instructions for editing files.

Header source code is:

` Githubissues.

  • Githubissues is a development platform for aggregating issues.